Refactor provider adapter registration by Copilot · Pull Request #8335 · github/gh-aw-firewall

Copilot · 2026-09-08T22:23:34Z

Provider registration repeated identical adapter creation and body-transform wiring for each provider. This centralizes the ordered registration definition while preserving provider order and behavior.

Registry
- Added a single PROVIDER_ADAPTER_FACTORIES table pairing each factory with its transform dependency key.
- Derived all adapters through the shared registry.
Coverage
- Added registry-level coverage for port order and provider-specific transform wiring.

const PROVIDER_ADAPTER_FACTORIES = [
  [createOpenAIAdapter, 'openaiBodyTransform'],
  [createAnthropicAdapter, 'anthropicBodyTransform'],
  // …
];

Fixes [Duplicate Code] Provider adapter registration repeats scaffold setup #8332

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Copilot

🟡 Changes recommended

The Copilot test must verify that the injected provider-specific transform receives the body.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Centralizes provider adapter registration while preserving provider order and transform wiring.

Changes:

Adds an ordered provider factory registry.
Builds adapters through the shared registry.
Adds ordering and transform-wiring tests.

File summaries

File	Description
`containers/api-proxy/providers/index.js`	Defines and consumes the shared adapter registry.
`containers/api-proxy/providers/index.test.js`	Tests ordering and transform wiring, but does not verify the injected Copilot transform is invoked.

Review details

Files reviewed: 2/2 changed files
Comments generated: 1
Review effort level: Balanced

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

github-actions · 2026-09-09T13:40:30Z

✅ Copilot review passed with no inline comments.

@copilot Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

github-actions · 2026-09-09T13:45:40Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	94.04%	94.05%	➡️ +0.01%
Statements	92.72%	92.73%	📈 +0.01%
Functions	93.41%	93.41%	➡️ +0.00%
Branches	86.63%	86.64%	📈 +0.01%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/log-directory-setup.ts`	96.2% → 100.0% (+3.78%)	96.3% → 100.0% (+3.71%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

github-actions · 2026-09-09T22:37:00Z

❌ Smoke Copilot BYOK AOAI (Entra) reports failed. AOAI BYOK (Entra) mode investigation needed...

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)

github-actions · 2026-09-09T22:37:03Z

❌ Smoke Gemini reports failed. Facets need polishing...

💎 Faceted by Smoke Gemini

github-actions · 2026-09-09T22:37:04Z

✅ Build Test Suite completed successfully!

Generated by Build Test Suite for #8335

github-actions · 2026-09-09T22:37:04Z

✅ Smoke Claude passed

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

api.anthropic.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.anthropic.com"

See Network Configuration for more information.

Generated by Smoke Claude for #8335

github-actions · 2026-09-09T22:37:05Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

Tested by Smoke Chroot

github-actions · 2026-09-09T22:37:07Z

✅ Security Guard completed successfully!

Security review complete: PR #8335 refactors provider adapter registration in containers/api-proxy/providers/index.js. No security-weakening changes detected. The refactoring consolidates duplicate instantiation code into a centralized PROVIDER_ADAPTER_FACTORIES array and uses .map() for adapter creation. This maintains the same dependency injection pattern, null handling, and credential isolation. No capabilities added, firewall rules changed, or secrets exposed. The change is purely a code-quality improvement with identical security properties.

Generated by Security Guard for #8335

github-actions · 2026-09-09T22:37:09Z

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

🔑 BYOK report filed by Smoke Copilot BYOK

github-actions · 2026-09-09T22:37:10Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-09-09T22:37:20Z

📰 DEVELOPING STORY: Smoke Docker Sbx reports failed. Our correspondents are investigating the incident...

📰 BREAKING: Report filed by Smoke Docker Sbx

github-actions · 2026-09-09T22:37:20Z

❌ Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed...

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)

github-actions · 2026-09-09T22:37:23Z

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

📡 OTel tracing validated by Smoke OTel Tracing

github-actions · 2026-09-09T22:37:26Z

🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

example.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "example.com"

See Network Configuration for more information.

🛡️ Egress verdict from Smoke Copilot Network Isolation

github-actions · 2026-09-09T22:37:33Z

🔌 Smoke Services — All services reachable! ✅

🔌 Service connectivity validated by Smoke Services

github-actions · 2026-09-09T22:38:15Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

msfeed25.pkgs.visualstudio.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "msfeed25.pkgs.visualstudio.com"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-09-09T22:40:59Z

@lpcox Smoke Test Results:

✅ MCP connectivity (PR #8351: chore(deps): upgrade gh-aw to v0.88.8)
✅ GitHub.com connectivity (HTTP 200)
✅ File write/read test

Overall: PASS

📰 BREAKING: Report filed by Smoke Copilot
_{Add label ready-for-aw to run again}

github-actions · 2026-09-09T22:41:14Z

Smoke Test: Claude Engine Validation

Check	Status
API	✅ PASS
gh CLI	✅ PASS
File	✅ PASS

Overall result: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

api.anthropic.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.anthropic.com"

See Network Configuration for more information.

Generated by Smoke Claude for #8335 · claude · haiku45 · 58.7 AIC · ⊞ 4.5K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-09-09T22:41:19Z

EGRESS_RESULT allow=pass deny=pass

✅ Allowed domain (github.com) reachable: allowed=200
✅ Blocked domain (example.com) denied: CONNECT tunnel 403

Overall: PASS

cc @lpcox

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

example.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "example.com"

See Network Configuration for more information.

🛡️ Egress verdict from Smoke Copilot Network Isolation
_{Add label ready-for-aw to run again}

github-actions · 2026-09-09T22:41:25Z

Smoke Test: Services Connectivity

Redis PING: ✅ PONG
PostgreSQL pg_isready: ✅ accepting connections
PostgreSQL SELECT 1: ✅ 1

Overall: PASS

🔌 Service connectivity validated by Smoke Services
_{Add label ready-for-aw to run again}

github-actions · 2026-09-09T22:42:16Z

✅ GitHub MCP: PR listings verified
✅ GitHub.com connectivity: HTTP 200
✅ File write/read: /tmp/gh-aw/agent/smoke-test-copilot-byok.txt exists
✅ BYOK inference: Direct mode working via api-proxy → api.githubcopilot.com

Status: PASS | Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY)

🔑 BYOK report filed by Smoke Copilot BYOK
_{Add label ready-for-aw to run again}

github-actions · 2026-09-09T22:42:44Z

Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.14	Python 3.12.14	✅ YES
Node.js	v24.20.0	v22.23.2	❌ NO
Go	go1.22.12	go1.22.12	✅ YES

Overall: FAILED — Node.js version mismatch between host and chroot environments. smoke-chroot label not added.

Tested by Smoke Chroot
_{Add label ready-for-aw to run again}

github-actions · 2026-09-09T22:43:26Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	1/1 passed	✅ PASS
Go	env	✅	1/1 passed	✅ PASS
Go	uuid	✅	1/1 passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	passed	✅ PASS
Node.js	execa	✅	passed	✅ PASS
Node.js	p-limit	✅	passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — PASS

Notes:

Java: Maven local repository was redirected to /tmp/gh-aw/agent/m2-repo because ~/.m2 was not writable in this environment; proxy settings (squid-proxy:3128) applied via ~/.m2/settings.xml as instructed.
All 18 test projects across 8 ecosystems (Bun, C++, Deno, .NET, Go, Java, Node.js, Rust) built/installed and passed their tests successfully.

Generated by Build Test Suite for #8335 · copilot · auto · 48.2 AIC · ⊞ 10.6K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-09-09T22:43:40Z

📡 OTel Tracing Smoke Test Results

#	Scenario	Result
1	Module Loading	✅ `otel.js` loaded, `isEnabled()`=true, exports 14 functions incl. `startRequestSpan`, `setTokenAttributes`, `endSpan`, `_FanOutSpanExporter`
2	Test Suite	✅ 68/68 tests passed across 3 suites (`otel.test.js`, `otel-fanout.test.js`, `otel-workload-identity.test.js`)
3	Env Var Forwarding	✅ `GITHUB_AW_OTEL_TRACE_ID`/`PARENT_SPAN_ID` present in `env-passthrough.ts`; `GH_AW_OTLP_ENDPOINTS`, `OTEL_EXPORTER_OTLP_ENDPOINT`, and trace context present in `api-proxy-env-config.ts`
4	Token Tracker Integration	✅ `onUsage` callback present in `token-tracker-http.js` as OTEL hook point
5	OTEL Diagnostics	✅ Workflow-level span export active (`/tmp/gh-aw/otel.jsonl`, 1 span record with `gen_ai.*` attrs); api-proxy sidecar `otel.jsonl` not present this run (no LLM calls routed through api-proxy sidecar), but `token-usage.jsonl` shows 6 tracked usage records — expected, no regression

Overall: all scenarios pass, no regressions detected.

📡 OTel tracing validated by Smoke OTel Tracing
_{Add label ready-for-aw to run again}

github-actions · 2026-09-09T22:44:30Z

Smoke test: FAIL

chore(deps): upgrade gh-aw to v0.88.8 #8351 chore(deps): upgrade gh-aw to v0.88.8
Sync runner-doctor catalog for ARC/DinD and host-gateway lessons #8330 Sync runner-doctor catalog for ARC/DinD and host-gateway lessons
GitHub reads ✅
Playwright title check ❌
File write/read ✅
Build (npm ci && npm run build) ✅
Discussion comment ❌
Overall: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

msfeed25.pkgs.visualstudio.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "msfeed25.pkgs.visualstudio.com"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

Initial plan

0023a92

Copilot AI assigned Copilot and lpcox Sep 8, 2026

Copilot started work on behalf of lpcox September 8, 2026 22:24 View session

Copilot AI linked an issue Sep 8, 2026 that may be closed by this pull request

[Duplicate Code] Provider adapter registration repeats scaffold setup #8332

Closed

refactor: centralize provider adapter registration

6602fe1

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix duplicate code in provider adapter registration~~ Refactor provider adapter registration Sep 8, 2026

Copilot finished work on behalf of lpcox September 8, 2026 22:28

Copilot AI requested a review from lpcox September 8, 2026 22:28

lpcox marked this pull request as ready for review September 8, 2026 23:20

Copilot AI balanced review requested due to automatic review settings September 8, 2026 23:20

Copilot started reviewing on behalf of lpcox September 8, 2026 23:21 View session

Copilot AI reviewed Sep 8, 2026

View reviewed changes

Comment thread containers/api-proxy/providers/index.test.js

Add test for copilotBodyTransform function

99b6b4b

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

lpcox added the ready-for-aw label Sep 9, 2026

lpcox had a problem deploying to aoai-model September 9, 2026 22:37 — with GitHub Actions Failure

lpcox deployed to aoai-model September 9, 2026 22:40 — with GitHub Actions Active

github-actions Bot added the smoke-copilot label Sep 9, 2026

github-actions Bot added the smoke-claude label Sep 9, 2026

github-actions Bot added the smoke-copilot-network-isolation Copilot network-isolation egress smoke test label Sep 9, 2026

github-actions Bot added the smoke-services label Sep 9, 2026

lpcox deployed to aoai-model September 9, 2026 22:41 — with GitHub Actions Active

github-actions Bot added the smoke-copilot-byok label Sep 9, 2026

lpcox merged commit 9e89cca into main Sep 9, 2026
169 of 176 checks passed

lpcox deleted the copilot/fix-duplicate-code-provider-adapter-registration branch September 9, 2026 23:35

Uh oh!

Conversation

Copilot AI commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026

Uh oh!

github-actions Bot commented Sep 9, 2026

✅ Coverage Check Passed

Overall Coverage

Uh oh!

github-actions Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026

Uh oh!

github-actions Bot commented Sep 9, 2026

Smoke Test: Claude Engine Validation

Uh oh!

github-actions Bot commented Sep 9, 2026

Uh oh!

github-actions Bot commented Sep 9, 2026

Smoke Test: Services Connectivity

Uh oh!

github-actions Bot commented Sep 9, 2026

Uh oh!

github-actions Bot commented Sep 9, 2026

Chroot Version Comparison Results

Uh oh!

github-actions Bot commented Sep 9, 2026

🏗️ Build Test Suite Results

Uh oh!

github-actions Bot commented Sep 9, 2026

📡 OTel Tracing Smoke Test Results

Uh oh!

github-actions Bot commented Sep 9, 2026

Copilot AI commented Sep 8, 2026 •

edited

Loading

github-actions Bot commented Sep 9, 2026 •

edited

Loading

github-actions Bot commented Sep 9, 2026 •

edited

Loading

github-actions Bot commented Sep 9, 2026 •

edited

Loading

github-actions Bot commented Sep 9, 2026 •

edited

Loading

github-actions Bot commented Sep 9, 2026 •

edited

Loading

github-actions Bot commented Sep 9, 2026 •

edited

Loading

github-actions Bot commented Sep 9, 2026 •

edited

Loading

github-actions Bot commented Sep 9, 2026 •

edited

Loading

github-actions Bot commented Sep 9, 2026 •

edited

Loading

github-actions Bot commented Sep 9, 2026 •

edited

Loading

github-actions Bot commented Sep 9, 2026 •

edited

Loading

github-actions Bot commented Sep 9, 2026 •

edited

Loading

github-actions Bot commented Sep 9, 2026 •

edited

Loading

github-actions Bot commented Sep 9, 2026 •

edited

Loading